[PATCH] net/wireless/reg.c: fix

From: Ingo Molnar
Date: Sun Nov 23 2008 - 11:07:55 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> -tip testing found this build failure:
>
> net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1
>
> with the attached config. Seems the macro confused some aspect of WARN()

looks like a genuine bug in net/wireless/reg.c.

accidentally gcc was too willing to build this nonsense:

if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)),
"Invalid Country IE regulatory hint passed "
"to the wireless core\n")

the fix is to use WARN(), which the intention was most likely.

Ingo

------------------->