Re: [PATCH 1/2] mmiotrace: fix buffer overrun detection

From: Ingo Molnar
Date: Sun Nov 23 2008 - 14:34:37 EST



* Pekka Paalanen <pq@xxxxxx> wrote:

> From d5d72f3515ba3abffa317b985d7597718a024841 Mon Sep 17 00:00:00 2001
> From: Pekka Paalanen <pq@xxxxxx>
> Date: Sun, 23 Nov 2008 19:18:18 +0200
> Subject: [PATCH] mmiotrace: fix buffer overrun detection
>
> When ftrace framework moved to use the ring buffer facility, the buffer
> overrun detection was broken after 2.6.27 by commit
>
> commit 3928a8a2d98081d1bc3c0a84a2d70e29b90ecf1c
> Author: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Date: Mon Sep 29 23:02:41 2008 -0400
>
> ftrace: make work with new ring buffer
>
> This patch ports ftrace over to the new ring buffer.
>
> The detection is now fixed by using the ring buffer API.
>
> When mmiotrace detects a buffer overrun, it will report the number of
> lost events. People reading an mmiotrace log must know if something was
> missed, otherwise the data may not make sense.
>
> Signed-off-by: Pekka Paalanen <pq@xxxxxx>
> ---
>
> Ingo, could these two patches still make it into .28?

Sure - applied them to tip/tracing/urgent:

fb91ee6: tracing, doc: update mmiotrace documentation
7ee1768: x86, mmiotrace: fix buffer overrun detection

Does this make mmiotrace fully functional in .28 ?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/