Re: [patch v2.6.28-rc6-28-g5bcdadf 6/7] usb: musb: use list_is_last

[Sergei Shtylyov]

Felipe Balbi wrote:

> > > diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> > > index d6a802c..b6aea0b 100644
> > > --- a/drivers/usb/musb/musb_gadget.c
> > > +++ b/drivers/usb/musb/musb_gadget.c
> > > @@ -1159,7 +1159,7 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req,
> > > 	list_add_tail(&(request->request.list), &(musb_ep->req_list));
> > >  	/* it this is the head of the queue, start i/o ... */
> > > -	if (!musb_ep->busy && &request->request.list == musb_ep->req_list.next)
> > > +	if (!musb_ep->busy && list_is_last(&request->request.list, &musb_ep->req_list))
> >
> >   This is not the same -- the replaced comparison checked if the request is
> > first in queue, not last. Look at the definition of that function:

> Good catch. Greg, please drop this patch.

   BTW, it's strange that there's list_is_last() but no list_is_first()...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/