Re: [PATCH 1/1] cpufreq: eeepc 900 frequency scaling driver

[Thomas Renninger]

On Monday 24 November 2008 10:38:58 am Tom Hughes wrote:
> Cristiano Prisciandaro wrote:
> > From: Cristiano Prisciandaro <cristiano.p@xxxxxxxxx>
> >
> > The bios of the eeepc 900 exposes an acpi method that allows clocking
> > the cpu to 630/900 MHz. This driver allows controlling the frequency
> > switch through the cpufreq subsystem.
>
> I should perhaps add at this point that I have an alternative patch
> based on Cristiano's code, which adds this cpufreq driver to the
> existing eeepc-laptop module rather than creating a separate module for it.
>
> Personally I'm quite happy with either solution so I'll leave it to you
> to decide what is the best way to go, but my patch is available if you
> want it.
Either way, shouldn't you be able to provide a dmi matching module alias:
MODULE_ALIAS("dmi:...")
for autoloading?

Or are these two cpufreq functions part of an ACPI device you could match for, 
then it should get an ACPI driver?
If this ACPI device provides more functions, then these should probably also
be added to this driver.
Splitting the OS drivers the same way as BIOS splits up functionality into
ACPI devices is a good idea.

Could you paste at least the whole ACPI device in which:
#define ASUS_CPUFV_READ_METHOD   "CFVG"
#define ASUS_CPUFV_WRITE_METHOD  "CFVS"
sit or better point to an acpidump/dsdt output.

     Thomas



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/