Re: [PATCH] create /proc/timer-wheel-list

From: Joe Korty
Date: Mon Nov 24 2008 - 14:12:21 EST


On Sun, Nov 23, 2008 at 05:04:24AM -0500, Ingo Molnar wrote:
>
> * Joe Korty <joe.korty@xxxxxxxx> wrote:
>
> > On Sat, Nov 22, 2008 at 12:34:23PM -0500, Alexey Dobriyan wrote:
> > > On Fri, Nov 21, 2008 at 05:11:13PM -0500, Joe Korty wrote:
> > > > Create /proc/timer_wheel_list.
> > > >
> > > > This does for the timer wheel what /proc/timer_list
> > > > does for hrtimers -- provide a way of displaying what
> > > > timers are running on what cpus, and their attributes.
> > >
> > > The fact that it's called a timer wheel is just an implementation detail
> > > unsuitable for permanent file.
> >
> > Agreed. I'll come up with something else. lrtimer_list is a good
> > candidate.
>
> no - please include it in /proc/timer_list instead. It already lists
> clockevents and hrtimers - listing timer-list timers would be a
> natural extension of that facility.

struct tvec_base and TVR_MASK & family are all local
to kernel/timers.c rather than in some header file,
so parts of the display code would need to remain in
kernel/timers.c. Seems ugly, but is of course do-able.

Also, I am not sure why we are lumping all sorts of
disparate things in one display file. Did proc files
become expensive somewhere along the line?

(Just asking before I go down a path that everyone will
hate, once they see the result).

Regards,
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/