Re: [PATCH] use limited register constraint for setnz

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Impact: fix in compiling
> 
> GCC can decide to use %dil when "r" is used, which is not valid for
> setnz.
> 
> This bug was brought out by Stephen Rothwell's merging of the
> branch tracer into linux-next.
> 
> Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
> 
> diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
> index 0be77b3..c2121d2 100644
> --- a/arch/x86/boot/tty.c
> +++ b/arch/x86/boot/tty.c
> @@ -74,7 +74,7 @@ static int kbd_pending(void)
>  {
>  	u8 pending;
>  	asm volatile("int $0x16; setnz %0"
> -		     : "=rm" (pending)
> +		     : "=Qm" (pending)
>  		     : "a" (0x0100));
>  	return pending;
>  }

applied to tip/x86/urgent, thanks Steve!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/