Re: [2.6.28-rc6] oprofile: "opcontrol --start" output two warnings

[Andi Kleen]

KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> writes:
>
> Index: b/arch/x86/oprofile/op_model_p4.c
> ===================================================================
> --- a/arch/x86/oprofile/op_model_p4.c	2008-11-24 06:20:04.000000000 +0900
> +++ b/arch/x86/oprofile/op_model_p4.c	2008-11-24 06:29:09.000000000 +0900
> @@ -399,6 +399,8 @@ static void p4_fill_in_addresses(struct 
>  	unsigned int i;
>  	unsigned int addr, cccraddr, stag;
>  
> +	get_cpu();

The whole thing seems broken anyways because the only caller of
fill_in_addresses only assigns to CPU 0 and fill_in_addresses only
runs on some CPU. So I guess the stagger handling could be just
removed because it's useless.

-Andi

-- 
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/