Re: [PATCH 1/2] power_supply: Add cold to the POWER_SUPPLY_HEALTHreport values

From: Anton Vorontsov
Date: Tue Nov 25 2008 - 06:25:28 EST


On Thu, Nov 20, 2008 at 03:23:40PM +0000, Mark Brown wrote:
> Some systems are able to report problems with batteries being under
> temperature.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Looks good to me.

Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>

> ---
> drivers/power/power_supply_sysfs.c | 2 +-
> include/linux/power_supply.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 23ae846..ac01e06 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -45,7 +45,7 @@ static ssize_t power_supply_show_property(struct device *dev,
> };
> static char *health_text[] = {
> "Unknown", "Good", "Overheat", "Dead", "Over voltage",
> - "Unspecified failure"
> + "Unspecified failure", "Cold",
> };
> static char *technology_text[] = {
> "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd",
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index f9348cb..8ff25e0 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -45,6 +45,7 @@ enum {
> POWER_SUPPLY_HEALTH_DEAD,
> POWER_SUPPLY_HEALTH_OVERVOLTAGE,
> POWER_SUPPLY_HEALTH_UNSPEC_FAILURE,
> + POWER_SUPPLY_HEALTH_COLD,
> };
>
> enum {
> --
> 1.5.6.5
>

--
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/