Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: changesimple_strtol to simple_strtoul

From: Ingo Molnar
Date: Tue Nov 25 2008 - 22:10:29 EST



* Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:

> On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@xxxxxxx>
> >
> > Since bridge is unsigned, it would seem better to use simple_strtoul that
> > simple_strtol.
> >
> > A simplified version of the semantic patch that makes this change is as
> > follows: (http://www.emn.fr/x-info/coccinelle/)
> >
> > // <smpl>
> > @r2@
> > long e;
> > position p;
> > @@
> >
> > e = simple_strtol@p(...)
> >
> > @@
> > position p != r2.p;
> > type T;
> > T e;
> > @@
> >
> > e =
> > - simple_strtol@p
> > + simple_strtoul
> > (...)
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
>
> Acked-by: Muli Ben-Yehuda <muli@xxxxxxxxxx>
>
> Ingo, can you please push?

Sure, applied to tip/x86/urgent, thanks guys!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/