Re: [PATCH 1/1] HID: Apple alu wireless keyboards are bluetooth devices

[J.R. Mauro]

On Wed, Nov 26, 2008 at 10:33 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Wed, 26 Nov 2008, Jan Scholz wrote:
>
>> Jiri Kosina <jkosina@xxxxxxx> writes:
>>
>> > On Wed, 26 Nov 2008, Jan Scholz wrote:
>> >
>> >> Changed HID_USB_DEVICE to HID_BLUETOOTH_DEVICE for the apple alu
>> >> wireless keyboards
>> >> Signed-off-by: Jan Scholz <Scholz@xxxxxxxxxxxxxxxxxxxxx>
>> >> ---
>> >>  drivers/hid/hid-apple.c |    6 +++---
>> >>  drivers/hid/hid-core.c  |    6 +++---
>> >>  2 files changed, 6 insertions(+), 6 deletions(-)
>> >>
>> >> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
>> >> index 9b97795..aa28aed 100644
>> >> --- a/drivers/hid/hid-apple.c
>> >> +++ b/drivers/hid/hid-apple.c
>> >> @@ -400,12 +400,12 @@ static const struct hid_device_id apple_devices[] = {
>> >>    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_JIS),
>> >>            .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN |
>> >>                    APPLE_RDESC_JIS },
>> >> -  { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>> >> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>> >>            .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
>> >> -  { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO),
>> >> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO),
>> >>            .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN |
>> >>                    APPLE_ISO_KEYBOARD },
>> >> -  { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS),
>> >> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS),
>> >>            .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
>> >>    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ANSI),
>> >>            .driver_data = APPLE_HAS_FN },
>> >
>> > Hi Jan,
>> >
>> > shouldn't we rather have both USB and Bluetooth variants?
>> >
>> > Thanks,
>>
>> Hi Jiri,
>>
>> Hm, I thought the USB_DEVICE_ID_APPLE_ALU_{ANSI,ISO,JIS} were apples usb
>> aluminum keyboards (standard desktop size), while the
>> USB_DEVICE_ID_APPLE_ALU_WIRELESS_{ANSI,ISO,JIS} ones were the aluminum
>> bluetooth keyboards (notebook sized, no numeric keypad, etc).
>>
>> The one I own is a USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO, german layout,
>> with bluetooth, unfortunately I don't have access to a usb variant.
>
> Tobias Mueller added these device IDs, so persumably he has tested it and
> could provide some insight. I don't have the hardware myself, so I have no
> idea whether there are only Bluetooht variants, or even USB are available.

There is one bluetooth model and one USB model.

>
> Tobias?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/