Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output

[Frédéric Weisbecker]

2008/11/27 Ingo Molnar <mingo@xxxxxxx>:
>
> * Frédéric Weisbecker <fweisbec@xxxxxxxxx> wrote:
>
>> >> >  0)    0.993 us |      }
>> >> > +0)   11.649 us |    }
>> >> >  0)             |    do_sync_read() {
>> >> >  0)             |      sock_aio_read() {
>> >> >  0)             |        __sock_recvmsg() {
>> >> >  0)             |          security_socket_recvmsg() {
>> >> > !0)  100.319 us |            cap_socket_recvmsg();
>> >> > ---------------------------------------------------------
>>
>> I like it before the CPU number. The main purpose would be to scroll
>> quickly the file and find the overheads. That would be easy if set
>> as a first character.
>>
>> I will set it as a default disabled option.
>
> lets keep it default-enabled, ok? It makes sense.

Ok.
BTW I understand why it is better to have a "pipe" if there is no time:

  0)             |    do_sync_read() {
  0)             |      sock_aio_read() {
  0)             |        __sock_recvmsg() {
  0)             |          security_socket_recvmsg() {

But I don't see why it is necessary to have one just after the time:

!0)  100.319 us |            cap_socket_recvmsg();

It appears to me as noise....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/