Re: [PATCH] markers: comment marker_synchronize_unregister() ondata dependency

[Ingo Molnar]

* Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> * Wu Fengguang (fengguang.wu@xxxxxxxxx) wrote:
> > On Thu, Nov 27, 2008 at 10:00:03AM +0200, Mathieu Desnoyers wrote:
> > > * Wu Fengguang (fengguang.wu@xxxxxxxxx) wrote:
> > > > +
> > > > +marker_synchronize_unregister() must be called before the first occurrence of
> > > 
> > > 
> > > You should probably say 
> > > 
> > > ".. must be called between probe unregistration and the first occurence
> > > of..."
> > > 
> > > Mathieu
> > 
> > That's much better!
> > 
> > With your comments I'd assume you reviewed this patch ;-)
> > 
> > Thanks,
> > Fengguang
> > ---
> > markers: comment marker_synchronize_unregister() on data dependency
> > 
> > Add document and comments on marker_synchronize_unregister(): it
> > should be called before freeing resources that the probes depend on.
> > 
> > Based on comments from Lai Jiangshan and Mathieu Desnoyers.
> > 
> > Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
> > Reviewed-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> > Signed-off-by: Wu Fengguang <wfg@xxxxxxxxxxxxxxx>
> 
> It looks good to me, thanks!
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>

applied to tip/tracing/markers, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/