Re: [PATCH] usb/serial: Add compat_ioctl pass-through

From: Arjan van de Ven
Date: Fri Nov 28 2008 - 20:22:23 EST


On Sat, 29 Nov 2008 01:10:57 +0000
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > Oh yes, it is -- serial_ioctl does:
> >
> > if (port->serial->type->ioctl) {
> > lock_kernel();
> > retval = port->serial->type->ioctl(tty, file, cmd,
> > arg); unlock_kernel();
> > } else
> >
> > I added the comment to make the difference in calling convention
> > documented in the header file at least, I didn't change the code.
>
> Gak I thought I'd killed all of those.
>
> Let me rephase it "It won't be next week" ;)

it's a double BKL since it's also using .ioctl not .unlocked_ioctl
(but then again we should just over time merge the two into a .ioctl
which is unlocked ;-)


--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/