Re: [PATCH] irq: sparseirq enabling v4

From: Ingo Molnar
Date: Sat Nov 29 2008 - 05:03:24 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> impact: new feature sparseirq

> ---
> arch/x86/Kconfig | 10
> arch/x86/include/asm/io_apic.h | 2
> arch/x86/include/asm/irq_vectors.h | 11
> arch/x86/kernel/io_apic.c | 625 ++++++++++++++++++++++---------------
> arch/x86/kernel/irq.c | 3
> arch/x86/kernel/irq_32.c | 2
> arch/x86/kernel/irq_64.c | 2
> arch/x86/kernel/irqinit_32.c | 3
> arch/x86/kernel/irqinit_64.c | 3
> arch/x86/kernel/setup.c | 2
> drivers/char/random.c | 22 -
> drivers/pci/intr_remapping.c | 76 ++++
> drivers/pci/msi.c | 55 ++-
> drivers/xen/events.c | 12
> fs/proc/stat.c | 17 -
> include/linux/interrupt.h | 2
> include/linux/irq.h | 54 +++
> include/linux/irqnr.h | 14
> include/linux/kernel_stat.h | 14
> include/linux/msi.h | 3
> include/linux/random.h | 51 +++
> init/main.c | 11
> kernel/irq/autoprobe.c | 15
> kernel/irq/chip.c | 3
> kernel/irq/handle.c | 187 ++++++++++-
> kernel/irq/proc.c | 6
> kernel/irq/spurious.c | 5
> 27 files changed, 891 insertions(+), 319 deletions(-)

very nice!

All the structural feedback i gave seems to be addressed properly, and
the patch has shrunk and consolidated nicely. I think we can start
splitting it up and applying it to tip/irq/sparseirq. We might notice a
few more details when that happens, on a per patch basis.

I started this by applying the whole patch and creating a good commit log
entry for it. Could you please use the commit log and create a split-up
series from it? Each main bullet point starting with " - " should go into
a separate patch - see the commit log below.

I've pushed it out into tip/irq/sparseirq, but not yet into tip/master.
Will rebase irq/sparseirq with the split-up series of 8-9 patches once
you send it.

Thanks,

Ingo


---------------->