Re: [PATCH][UML] Boot broken due to buffer overrun

[Balbir Singh]

* Pekka Enberg <penberg@xxxxxxxxxxxxxx> [2008-11-29 12:21:46]:

> Hi Balbir,
> 
> On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh
> <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while
> > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids
> > a big overrun bug reported on UML bootup.
> 
> Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX
> long which causes the problem?
>

Yes, the changelog can definitely add that to the changelog, I'll
resend the patch if Jeff asks for it.

 
> > Reported-by: Vikas K Managutte <vikki.km@xxxxxxxxx>
> > Reported-by: Sarvesh Kumar Lal Das <skldas@xxxxxxxxx>
> > Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

Thanks!

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/