Re: [PATCH] tracing/branch-tracer: include missing irqflags.h

[Alexey Dobriyan]

On Sat, Nov 29, 2008 at 10:16:47AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 
> > Impact: fix build error on branch tracer
> > 
> > This should fix a build error reported on alpha in linux-next:
> > 
> >  CC      kernel/trace/trace_branch.o
> > kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> > kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> > kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'
> 
> applied to tip/tracing
> 
> > Unfortunately, I can't test it since I don't have any Alpha build 
> > environment.
> 
> it does not trigger with an Alpha defconfig - we do test that.
> 
> And the thing is, lockdep (which introduced irqflags tracing) has been 
> introduced upstream two years ago - and Alpha still does not have it 
> implemented. The architecture should be marked CONFIG_BROKEN if it 
> continues to cause problems like this.

Or people can, horror, cross-compile stuff in relevant configurations.

> Alexey, you seem to be using and relying on the Alpha architecture,

No, just alpha is first on the list ('a'), so nastygrams get sent first.

> could you please have a shot at this and implement the missing irqflags
> infrastructure?

Maybe. Should be interesting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/