Re: [PATCH 0/3] cgroup id and scanning without cgroup_lock

From: KAMEZAWA Hiroyuki
Date: Mon Dec 01 2008 - 02:53:15 EST


On Mon, 1 Dec 2008 11:54:29 +0530
Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> [2008-12-01 14:59:07]:
>
> > This is a series of patches againse mmotm-Nov29
> > (passed easy test)
> >
> > Now, memcg supports hierarhcy. But walking cgroup tree in intellegent way
> > with lock/unlock cgroup_mutex seems to have troubles rather than expected.
> > And, I want to reduce the memory usage of swap_cgroup, which uses array of
> > pointers.
> >
> > This patch series provides
> > - cgroup_id per cgroup object.
> > - lookup struct cgroup by cgroup_id
> > - scan all cgroup under tree by cgroup_id. without mutex.
> > - css_tryget() function.
> > - fixes semantics of notify_on_release. (I think this is valid fix.)
> >
> > Many changes since v1. (But I wonder some more work may be neeeded.)
> >
> > BTW, I know there are some amount of patches against memcg are posted recently.
> > If necessary, I'll prepare Weekly-update queue again (Wednesday) and
> > picks all patches to linux-mm in my queue.
> >
>
> Thanks for the offer, I've just come back from foss.in. I need to look
> athe locking issue with cgroup_lock() reported and also review/test
> the other patches.
>
Hmm, after reading mailing list again, it seems it's better to do some serialization.
I'll pick up some and post a queue tomorrow.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/