Re: [rfc git patch] union directory

[Miklos Szeredi]

On Mon, 1 Dec 2008, Bharata B Rao wrote:
> On Mon, Dec 01, 2008 at 10:05:09AM +0530, Bharata B Rao wrote:
> > On Sat, Nov 29, 2008 at 05:33:19PM +0100, Miklos Szeredi wrote:
> > > On Fri, 28 Nov 2008, Bharata B Rao wrote:
> > > 
> > > The plan is to get a simple kernel implementation first which caches
> > > the directory in 'struct file'.
> > 
> > FYI, I did this for a version of Union Mount.
> > (http://lkml.org/lkml/2007/6/20/21) I was maintaining the readdir cache in
> > struct file and the cache was persistant across readdir calls.
> > 
> > Do you have anything different in mind ?

Thanks for the pointer.  Yes something like that.

> 
> The version pointed to by me above had the entire cache stored
> in the struct file of the topmost directory. I guess your plan
> is to cache them per branch and combine them during
> readdir()/getdents() ?

No, the plan is to cache it in the struct file of the topmost
directory.  This should also solve the lseek() issue.

The only concern is that this caching behavior can waste unswappable
kernel memory.  But unless some malicious application actually wants
to exploit this, I don't think it will be a big issue in practice.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/