Re: [RFC 5/8] param: arch_get_boot_command_line()

From: Haavard Skinnemoen
Date: Tue Dec 02 2008 - 04:39:36 EST


Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Monday 01 December 2008 23:48:07 Russell King wrote:
> > So there's quite a bit which needs to be done to get at the command line.
> > Basically, what's required is:
> >
> > - convert param struct to tag list
> > - if no tag list, use default tag list
> > - run machine specific fixups which may set memory layout
> > - if memory layout has been set, kill off any memory atags to prevent it
> > being overwritten
> > - parse all atags which includes setting the command line if such a tag
> > is found
> >
> > Then, and only then can you be sure that you have the right command line.
>
> Thanks for the clue donation. I've read the code harder now. Tricky.

I think avr32 might need something similar as it also gets the command
line from a tag list. But we never really do anything tricky with those
tags, so I think it should work to simply move the call to parse_tags()
from setup_arch() into arch_get_boot_command_line().

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/