Re: [patch 2.6.28-rc7] regulator: catch some registration errors

From: Mark Brown
Date: Tue Dec 02 2008 - 08:32:41 EST


On Mon, Dec 01, 2008 at 09:50:35PM -0800, David Brownell wrote:

> Prevent registration of duplicate "struct regulator" names.
> They'd be unavailable, and clearly indicate something wrong.

This bit is good but...

> Also make sure the consumer device is provided. It's nonsensical
> to omit these, and not a documented part of the interface. Since
> no code in mainline does such stuff, this is just anti-oops medicine.

...we do still need to cater for cpufreq and other struct deviceless
consumers. If you can guarantee that no such consumers will ever exist
then great but we're not there yet.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/