Re: [PATCH 1/1] Char: n_tty, include module.h

From: Jiri Slaby
Date: Wed Dec 03 2008 - 10:35:45 EST


Alan Cox napsal(a):
> On Wed, 03 Dec 2008 16:17:52 +0100
> Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
>
>> On 12/03/2008 01:43 PM, Alan Cox wrote:
>>> On Wed, 3 Dec 2008 13:28:58 +0100
>>> Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
>>>
>>>> Since we are using EXPORT_SYMBOL, we should include linux/module.h
>>>>
>>>> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
>>> NAK
>>>
>>> n_tty doesn't use EXPORT_SYMBOL.
>> Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a
>> ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix
>
> And that patch isn't going in either. Ask Andrew to drop it instead. If
> the rest of the PPS stuff goes in then I'll redo that part of the n_tty
> stuff differently and cleanly.

Fair enough. Andrew, could you?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/