Re: [PATCH 1/3] ftrace: graph of a single function

[Andrew Morton]

On Wed, 3 Dec 2008 16:10:38 -0500 (EST)
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> 
> On Wed, 3 Dec 2008, Andrew Morton wrote:
> 
> > On Wed, 03 Dec 2008 15:36:57 -0500
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > 
> > > +static int g_show(struct seq_file *m, void *v)
> > > +{
> > > +	unsigned long *ptr = v;
> > > +	char str[KSYM_SYMBOL_LEN];
> > > +
> > > +	if (!ptr)
> > > +		return 0;
> > > +
> > > +	kallsyms_lookup(*ptr, NULL, NULL, NULL, str);
> > > +
> > > +	seq_printf(m, "%s\n", str);
> > 
> > Can we use %pF here?
> 
> If there's a way to not print the "+offset".

Could be added, I guess.  I wonder if it would be
reused elsewhere.

> blk_unplug looks much nicer than blk_unplug+0x78/0x278

<mutters something about in-kernel pretty-printers>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/