Re: [PATCH 1/3] x86: fix warning of uninitialized variable

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Jianjun Kong <jianjun@xxxxxxxxx> wrote:
> 
> > fix warning of uninitialized 'base' in arch/x86/kernel/scx200_32.c
> > 
> > arch/x86/kernel/scx200_32.c: In function âscx200_probeâ:
> > arch/x86/kernel/scx200_32.c:82: warning: âbaseâ may be used
> > uninitialized in this function
> > 
> > Signed-off-by: Jianjun Kong <jianjun@xxxxxxxxx>
> > ---
> >  arch/x86/kernel/scx200_32.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> this patch is wrong, and your analysis-free commit log is wrong as 
> well!
> 
> i fixed this a few weeks ago, and GCC pinpointed a _real_ bug - which 
> you hacked around instead of fixing. See the real fix below.

Also, see an example below of the case where GCC is wrong about a 
warning, and how it is annotated.

	Ingo

------------->