Re: 2.6.28-rc6: early panic with boot option "nosmp"

[Andi Kleen]

> The exception raised on dereferencing mpf or mpf_found.

This obvious patch should fix it then. Does it?

--

Fix early exception in __get_smp_config with nosmp

Bail out early when there is no MP table.

Reported by Wu Fengguang
Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

---
 arch/x86/kernel/mpparse.c |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c
===================================================================
--- linux-2.6.28-rc4-test.orig/arch/x86/kernel/mpparse.c	2008-10-24 13:34:40.000000000 +0200
+++ linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c	2008-12-04 13:20:34.000000000 +0100
@@ -604,6 +604,9 @@
 		printk(KERN_INFO "Using ACPI for processor (LAPIC) "
 		       "configuration information\n");
 
+	if (!mpf)
+		return;
+
 	printk(KERN_INFO "Intel MultiProcessor Specification v1.%d\n",
 	       mpf->mpf_specification);
 #if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86_32)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/