Re: [PATCH v2] crypto: des3_ede: permit weak keys unlessREQ_WEAK_KEY set

From: Herbert Xu
Date: Fri Dec 05 2008 - 10:24:43 EST


On Fri, Dec 05, 2008 at 10:03:53AM -0500, Jarod Wilson wrote:
>
> if (unlikely(!((K[0] ^ K[2]) | (K[1] ^ K[3])) ||
> - !((K[2] ^ K[4]) | (K[3] ^ K[5]))))
> + !((K[2] ^ K[4]) | (K[3] ^ K[5]))) &&
> + (*flags & CRYPTO_TFM_REQ_WEAK_KEY))
> {
> *flags |= CRYPTO_TFM_RES_BAD_KEY_SCHED;

This should be changed to RES_WEAK_KEY.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/