Re: [linux-pm] [PATCH 1/3] PCI: Rework default handling of suspendand resume

From: Arjan van de Ven
Date: Sat Dec 06 2008 - 18:25:16 EST


On Sat, 6 Dec 2008 14:24:55 -0800 (PST)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

>
>
> On Sat, 6 Dec 2008, Rafael J. Wysocki wrote:
> >
> > However, I'm not quite sure about the freeing and requesting IRQs
> > during suspend and resume. Many drivers do that, many others
> > don't. Still, apparently some drivers don't work correctly after
> > resume if this is not done. So, if that should generally be done, I
> > also think that moving it to the core might be a good idea.
>
> I'd suggest against it.
>
> A lot of drivers that want to disable (or unregister) interrupts
> almost certainly want to do it simply because they are not ready and
> willing to handle any interrupts after having run their "suspend()"
> function.

the problem is that the system bios can have reassigned interrupts
after resume, and afaik we need to re-evaluate the ACPI methods to
get the new mapping.
So we need to unregister + re-register to make that happen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/