Re: [W1] List slaves commands.

From: Andrew Morton
Date: Mon Dec 08 2008 - 16:59:42 EST


On Fri, 5 Dec 2008 15:41:27 +0300
Evgeniy Polyakov <zbr@xxxxxxxxxxx> wrote:

> + u64 *data = (void *)(cmd + 1) + cmd->len;
> +
> + *data = rn;

This code performs quite a lot of potentially unaligned acceses.

Is there anything which guarantees that all these accesses are
well-aligned?

If not, will there be issues with platforms which don't handle
unaligned accesses as well as x86?

Should this code be using the unaligned access interfaces
(get_unaligned, put_unaligned, etc. Might be wrong. Keeps changing.
Harvey Harrison is the guy to ask)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/