Re: [PATCH] Make Documentation/kobject.txt a little more coherent.

From: Eric W. Biederman
Date: Mon Dec 08 2008 - 17:56:54 EST


Rusty Russell <rusty@xxxxxxxxxxxxxxx> writes:

> While reading Documentation/kobject.txt:
>
> Note kobject_rename does perform any locking or have a solid notion of
> what names are valid so the provide must provide their own sanity checking
> and serialization.
>
> I expect better: You never see me hard with time word making sentence
> coherent stuff. Ever.
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Yes. That does sound better.


> diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt
> --- a/Documentation/kobject.txt
> +++ b/Documentation/kobject.txt
> @@ -118,8 +118,8 @@ the name of the kobject, call kobject_re
>
> int kobject_rename(struct kobject *kobj, const char *new_name);
>
> -Note kobject_rename does perform any locking or have a solid notion of
> -what names are valid so the provide must provide their own sanity checking
> +kobject_rename does not perform any locking or have a solid notion of
> +what names are valid so the caller must provide their own sanity checking
> and serialization.
>
> There is a function called kobject_set_name() but that is legacy cruft and
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/