Re: Checking link targets are NULL-terminated

[Christoph Hellwig]

On Mon, Dec 08, 2008 at 02:30:03PM -0800, Andrew Morton wrote:
> Perhaps nd_set_link() is a suitable place?  Change that function so
> that it is passed a third argument (max_len) and then check that within
> nd_set_link().  Change nd_set_link() to return a __must_check-marked
> errno, change callers to handle errors appropriately.
> 
> Or something totally different ;)  But along those lines?

Note that XFS and possibly other filesystem don't store the NULL
termination on disk.  So having a follow_link interface that uses a
counted string would be a nice little optimization for the XFS
follow_link / readlink implementation.   But I'm not really sure it's
worth complicating the VFS for that little gem.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/