Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

From: Joerg Roedel
Date: Wed Dec 10 2008 - 13:43:27 EST


On Wed, Dec 10, 2008 at 06:24:35PM +0000, David Woodhouse wrote:
> On Wed, 2008-12-10 at 15:25 +0100, Joerg Roedel wrote:
> > I already did it on-top of your tree because Han Weidong's patches 1-17
> > were rebased to your tree and my IOMMU-API patches apply on-top of his
> > patches.
>
> OK, thanks. Looks like you still need this though, as Mike Day pointed
> out:
>
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index 97df47c..a5f6e28 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -204,7 +204,7 @@ static inline bool dma_pte_present(struct dma_pte *pte)
> }
>
> /* devices under the same p2p bridge are owned in one domain */
> -#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0)
> +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 << 0)
>
> /* domain represents a virtual machine, more than one devices
> * across iommus may be owned in one domain, e.g. kvm guest.

Ok, I add it, thanks. Who is the author, Mike or you?

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/