Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system_hash

From: Pekka Enberg
Date: Thu Dec 11 2008 - 14:51:47 EST


On Thu, 2008-12-11 at 17:38 +0000, Catalin Marinas wrote:
>> Do you mean a comment? I can do this.

On Thu, Dec 11, 2008 at 7:45 PM, Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> wrote:
> Yeah, something like
>
> /*
> * kmemleak doesn't actually allocate memory when called this early
> * so the GFP_ATOMIC here is actually meaningless, but consistent
> * with the rest of this function.
> */
>
> Maybe that's too verbose. :)

I'd suggest just doing a separate kmemleak_early_alloc() hook without
the gfp flag.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/