Re: [RFC PATCH 02/12] net: infrastructure for hardware time stamping

From: Herbert Xu
Date: Mon Dec 15 2008 - 16:53:45 EST


Patrick Ohly <patrick.ohly@xxxxxxxxx> wrote:
> @@ -305,6 +406,8 @@ struct sk_buff {
> ipvs_property:1,
> peeked:1,
> nf_trace:1;
> + /* not all of the bits in optional are used */
> + __u8 optional;
> __be16 protocol;

You do reliase that this is going to grow the sk_buff by at least
4 bytes and not 1?

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/