Re: [PATCH, RESEND] introduce get_mm_hiwater_xxx(), fixtaskstats->hiwater_xxx accounting

[Jiri Pirko]

On Mon, 15 Dec 2008 16:21:48 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> 
> > +#define get_mm_hiwater_rss(mm)	max((mm)->hiwater_rss, get_mm_rss(mm))
> 
> This evaluates its argument thrice.
> 
> > +#define get_mm_hiwater_vm(mm)	max((mm)->hiwater_vm, (mm)->total_vm)
> 
> This evaluates its argument twice.
> 
> 
> was sched.h the appropriate header in which to implement these?  Maybe...
I think it was. There are similar helpers at the same place.
> 
> But they're only ever _used_ in kernel/tsacct.c, so do they actually
> need to be implemented in any .h file?
Yes because my patch (ru_maxrss filling) will be using
get_mm_hiwater_rss() from kernel/exit.c and kernel/sys.c
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/