Re: [Patch 3/3] via-sdmmc: via-sdmmc.h

[Arnd Bergmann]

On Tuesday 16 December 2008, JosephChan@xxxxxxxxxx wrote:
> Header file of VIA MSP SD/MMC card reader driver.
> 

The order of your patches is reversed, you add the Kconfig/Makefile
changes last so that the tree stays 'bisectable', i.e. you don't
have a broken build in the middle between your patches.

Since your header file is not an interface but only used in a single
source file, I would also suggest merging it into the main via-sdmmc.c
file, add changing Kconfig/Makefile in the same patch.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/