Re: [PATCH 3/15] sanitize audit_ipc_obj()

From: James Morris
Date: Wed Dec 17 2008 - 04:54:33 EST


On Wed, 17 Dec 2008, Al Viro wrote:

> On Wed, Dec 17, 2008 at 06:24:40PM +1100, James Morris wrote:
> > On Wed, 17 Dec 2008, Al Viro wrote:
> >
> > > + struct {
> > > + uid_t uid;
> > > + gid_t gid;
> > > + mode_t mode;
> > > + u32 osid;
> > > + } ipc;
> >
> > 'osid' should be converted into 'secid' someday.
>
> Eh? Do you mean the field name there or the actual output? Either is
> trivial, of course, but the latter is up to userland folks and the
> former alone seems to be rather pointless...

I was thinking in terms of the kernel API, where 'secid' is the preferred
name for security identifiers ('sid' being an SELinux-specific term and
also conflicting with 'session id'). Given that it's exposed to userland,
I guess it's too late.


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/