Re: [PATCH 1/28] drivers/base/platform.c: Drop return value fromplatform_driver remove functions

From: Greg KH
Date: Wed Dec 17 2008 - 16:48:46 EST


On Fri, Dec 12, 2008 at 04:00:02PM -0500, Mike Frysinger wrote:
> On Fri, Dec 12, 2008 at 00:17, Greg KH wrote:
> > On Wed, Dec 10, 2008 at 05:37:42PM -0500, Mike Frysinger wrote:
> >> On Wed, Dec 10, 2008 at 17:18, Vorobiev Dmitri wrote:
> >> >> On Wed, Dec 10, 2008 at 11:26, Julia Lawall wrote:
> >> >> you'll get a
> >> >> warning in C about the assignment, but you wont get a build failure,
> >> >
> >> > ...unless you compile with -Werror, which frequently the case.
> >>
> >> anyone crazy enough to build with -Werror is crazy enough to send in a fix ;)
> >
> > Hm, have you noted that some arches have that flag enabled in their
> > build?
>
> i dont see anyone building things beyond a select dir or two (none of
> which contain platform drivers) with -Werror. where are you seeing
> this ?

Sparc builds add this from what I remember, I've broken their build at
times by adding unnecessary errors and got an inbox full of emails about
it :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/