Re: mmotm 2008-12-16-00-43 uploaded (fs)

[KOSAKI Motohiro]

> On Tue, 16 Dec 2008 10:00:56 -0800 Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> 
> > Randy Dunlap wrote:
> > > akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > >> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
> > >>
> > >>    http://userweb.kernel.org/~akpm/mmotm/
> > >>
> > >> It contains the following patches against 2.6.28-rc8:
> > >>
> > >> fs-symlink-write_begin-allocation-context-fix.patch
> > > 
> > > Nick,
> > > 
> > > fuse and reiser4 still use __grab_cache_page() although your patch
> > > removed it:
> > > 
> > > build-r7257.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/reiser4/plugin/file/file_conversi
> > > on.c:689: error: implicit declaration of function '__grab_cache_page'
> > > build-r7257.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> > > 
> > > build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/fuse/file.c:792: error: implicit declaration of function '__grab_cache_page'
> > > build-r7248.out:make[3]: *** [fs/fuse/file.o] Error 1
> > 
> > 
> > One more related error:
> > 
> > build-r7258.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
> > build-r7258.out:make[3]: *** [fs/ubifs/file.o] Error 1
> 
> thanks, I dropped it.

I'm sad ;)

I have fixing patch. this patch series have

1) reiser4 fix
2) ubifs fix
3) fuse fix



Tested on mmotm1217 + fs-symlink-write_begin-allocation-context-fix.patch

==
Subject: [PATCH 1/3] fix reiser4 build error of fs-symlink-write_begin-allocation-context-fix.patch

build fix.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
---
 fs/reiser4/plugin/file/file_conversion.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/fs/reiser4/plugin/file/file_conversion.c
===================================================================
--- a/fs/reiser4/plugin/file/file_conversion.c
+++ b/fs/reiser4/plugin/file/file_conversion.c
@@ -686,7 +686,8 @@ int reiser4_write_begin_careful(struct f
 	start = pos & (PAGE_CACHE_SIZE - 1);
 	end = start + len;
 
-	page = __grab_cache_page(mapping, index);
+	page = grab_cache_page_write_begin(mapping, index,
+					   flags & AOP_FLAG_NOFS);
 	*pagep = page;
 	if (!page)
 		return -ENOMEM;




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/