Re: [PATCH] x86: process.c declare c1e_remove_cpu before they getused

From: Ingo Molnar
Date: Thu Dec 18 2008 - 07:36:38 EST



* Jaswinder Singh <jaswinder@xxxxxxxxxxxxx> wrote:

> Impact: cleanup
>
> Included asm/idle.h for c1e_remove_cpu declaration.
>
> Signed-off-by: Jaswinder Singh <jaswinder@xxxxxxxxxxxxx>
> ---
> arch/x86/kernel/process.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index f50f8bf..25313de 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -10,6 +10,7 @@
> #include <linux/ftrace.h>
> #include <asm/system.h>
> #include <asm/apic.h>
> +#include <asm/idle.h>
>
> unsigned long idle_halt;
> EXPORT_SYMBOL(idle_halt);

hm, why is this needed? Have you seen a compiler warning?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/