Re: [PATCH] bitmap: fix bitmap_find_free_region()

From: Pekka Enberg
Date: Fri Dec 19 2008 - 09:00:09 EST


On Fri, 19 Dec 2008, Johannes Weiner wrote:
>> And return -ENOSPC?

On Fri, Dec 19, 2008 at 3:18 PM, Guennadi Liakhovetski <lg@xxxxxxx> wrote:
> So, you agree that a check should be added to bitmap_find_free_region()?
> As for details - to warn or not to warn and what error code to return,
> that can be discussed, although "No space left on device" doesn't seem to
> fit very well IMHO:-)

Yeah, but ENOMEM, on the other had, is mostly for out-of-memory
conditions so EINVAL might be more appropriate.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/