Re: [patch 3/8] SDHCI: Add set_ios hook

[Pierre Ossman]

On Tue, 02 Dec 2008 15:40:21 +0000
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> Add a set_ios hook which is called when the SDHCI driver
> is called to change parameters such as clock or card
> width.
> 
> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>
> 

NAK. As I explained earlier, this is a too broad hook and you haven't
given a proper reason for examining the card structure (which is all
that the set_ios callback does).

-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Attachment: signature.asc
Description: PGP signature