Re: [PATCH 01/14] kmemleak: Add the base support

From: Catalin Marinas
Date: Mon Dec 22 2008 - 08:06:01 EST


On Fri, 2008-12-19 at 14:14 -0800, Andrew Morton wrote:
> On Fri, 19 Dec 2008 23:02:55 +0100
> Ingo Molnar <mingo@xxxxxxx> wrote:
> > * Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> > > On Fri, Dec 19, 2008 at 8:13 PM, Catalin Marinas
> > > <catalin.marinas@xxxxxxx> wrote:
> > > > This patch adds the base support for the kernel memory leak
> > > > detector. It traces the memory allocation/freeing in a way similar to
> > > > the Boehm's conservative garbage collector, the difference being that
> > > > the unreferenced objects are not freed but only shown in
> > > > /sys/kernel/debug/kmemleak. Enabling this feature introduces an
> > > > overhead to memory allocations.
> > > >
> > > > Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > > Cc: Ingo Molnar <mingo@xxxxxxx>
> > > > Cc: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > > Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > >
> > > Looks good to me. I have only reviewed this lightly but all my major
> > > concerns have been addressed so feel free to add my:
> > >
> > > Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >
> > Andrew, do you have any principial objections against having this in
>
> Nope.
>
> > v2.6.29?
>
> That might be a bit harder. I'll take a look.

Thanks. Whenever you have time, the up to date kmemleak version
(currently based on v2.6.28-rc9) can be pulled from this branch:

git://linux-arm.org/linux-2.6.git kmemleak

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/