Re: [Linux-fbdev-devel] [PATCH 3/4 v5] i.MX31: framebuffer driver

[Geert Uytterhoeven]

On Mon, 22 Dec 2008, Guennadi Liakhovetski wrote:
> --- /dev/null
> +++ b/drivers/video/mx3fb.c
> @@ -0,0 +1,1853 @@

> +/**
> + * mx3fb_check_var() - check and adjust framebuffer variable parameters.
> + *
> + * @var:	framebuffer variable parameters
> + * @fbi:	framebuffer information pointer
> + */
> +static int mx3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *fbi)
> +{

    [...]

> +	/* Copy nonstd field to/from sync for fbset usage */
> +	var->sync |= var->nonstd;
> +	var->nonstd |= var->sync;

What's the purpose of this (ab)use of .nonstd?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/