Re: [patch 3/3] acpi: check for pxm_to_node_map overflow

[Cyrill Gorcunov]

[Ingo Molnar - Fri, Jan 02, 2009 at 10:23:30AM +0100]
| 
| * Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
| 
| > It is hardly (if ever) possible but in case of broken _PXM
| > entry we could reach out of pxm_to_node_map array
| > bounds in acpi_map_pxm_to_node() call. Lets check it
| > (it's not that expensive and safe).
| > 
| > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
| > CC: Len Brown <lenb@xxxxxxxxxx>
| > ---
| >  drivers/acpi/numa.c |    2 +-
| >  1 file changed, 1 insertion(+), 1 deletion(-)
| 
| just curious - how did you find this - code review or some tool help like 
| Sparse output or a compiler warning?
| 
| 	Ingo
| 

Unfortunately -- by reading the code :( I would prefer
if gcc or sparse complain about it but we have indirect
referring which is that hard to trace by any tool I believe
(until say some emulator but even if we have such kind of
tool we would need to tell it that 'there we have boundries
we shouldn't cross)'. But to be fair -- I didn't try sparse
here maybe it does complain :)

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/