[PATCH] kbuild: Remove gcc 4.1.0 quirk from init/main.c

[Ingo Molnar]

* Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:

> On Friday 02 January 2009, Ingo Molnar wrote:
> > 
> > * David Miller <davem@xxxxxxxxxxxxx> wrote:
> > 
> > > From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > > Date: Wed, 31 Dec 2008 13:22:53 -0800 (PST)
> > > 
> > > > On Wed, 31 Dec 2008, Andrew Morton wrote:
> > > > > 
> > > > > Adrian claimed that it was gcc-4.1.0 and 4.1.1 only.  He proposed
> > > > > banning them: http://lkml.org/lkml/2008/8/5/444
> > > > 
> > > > If it really is just those releases, then yes, considering the number 
> > > > of cases we apparently have, and considering how ugly it is in some 
> > > > cases to move the weak function anywhere else, maybe banning those 
> > > > versions is the proper thing to do.
> > > > 
> > > > It probably won't hurt very many people - yeah, some people will be 
> > > > forced to upgrade, but I have this memory of early 4.1 having had 
> > > > other bugs anyway, so it's probably a good idea.
> > > 
> > > I think this is probably the best way to handle this.
> > 
> > okay - to move this matter from the discussion-space to the 
> > solution-space, how about the patch below? (tested on x86 with a 
> > non-affected compiler version.)
> 
> ...or we can just merge Adrian's patch from June 2008 which also fixes 
> the issue nicely.

didnt know about that patch, but yeah, sure.

> OTOH your patch has an advantage of addressing the problem in the more 
> appropriate place (include/linux/compiler.h) and from what I see allows 
> us to remove previous gcc 4.1.0 check from init/main.c?

Good spotting - find followup cleanup patch below.

	Ingo

------------------->