Re: [PATCH] x86: nmi.c fix style problems

[Ingo Molnar]

* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxxxxx> wrote:

> Impact: cleanup, fix style problems
> 
> Fixes style problems:
> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
> WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>
> 
> total: 0 errors, 2 warnings
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
>  arch/x86/kernel/nmi.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
> index 8bd1bf9..45a09cc 100644
> --- a/arch/x86/kernel/nmi.c
> +++ b/arch/x86/kernel/nmi.c
> @@ -26,11 +26,10 @@
>  #include <linux/kernel_stat.h>
>  #include <linux/kdebug.h>
>  #include <linux/smp.h>
> +#include <linux/nmi.h>
>  
>  #include <asm/i8259.h>
>  #include <asm/io_apic.h>
> -#include <asm/smp.h>
> -#include <asm/nmi.h>
>  #include <asm/proto.h>
>  #include <asm/timer.h>

does this build fine on UP + IOAPIC ? asm/smp.h has some side-effects that 
brings in certain APIC definitions.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/