Re: [PATCH] Fix rcutree grace-period-latency bug on small systems

[Ingo Molnar]

* Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

> Kudos to Andi Kleen for finding a grace-period-latency problem!  The
> problem was that the special-case code for small machines never updated
> the ->signaled field to indicate that grace-period initialization had
> completed, which prevented force_quiescent_state() from ever expediting
> grace periods.  This problem resulted in grace periods extending for more
> than 20 seconds.  Not subtle.  I introduced this bug during my inspection
> process when I fixed a race between grace-period initialization and
> force_quiescent_state() execution.
> 
> The following patch properly updates the ->signaled field for the
> "small"-system case (no more than 32 CPUs for 32-bit kernels and no more
> than 64 CPUs for 64-bit kernels).
> 
> I believe that this patch should be included for 2.6.29.
> 
> Located-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Tested-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> 
>  rcutree.c |    1 +
>  1 file changed, 1 insertion(+)

Applied to tip/core/urgent, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/