Re: [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers

[Dan Williams]

On Mon, Jan 5, 2009 at 2:02 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> On Mon, 5 Jan 2009, Dan Williams wrote:
>
>> On Fri, Dec 26, 2008 at 10:11 AM, Guennadi Liakhovetski
>> <g.liakhovetski@xxxxxx> wrote:
>> > Hi,
>> >
>> > This is version 6 of dmaengine and framebuffer drivers for i.MX31.
>> >
>>
>> Tha drivers/dma/ bits look ok to me minus the new warnings:
>>
>> drivers/dma/ipu/ipu_irq.c: In function 'ipu_irq_fn':
>> drivers/dma/ipu/ipu_irq.c:328: warning: 'irq' may be used
>> uninitialized in this function
>> drivers/dma/ipu/ipu_irq.c: In function 'ipu_irq_err':
>> drivers/dma/ipu/ipu_irq.c:290: warning: 'irq' may be used
>> uninitialized in this function
>
> Wow... with what gcc version? My 4.1.2 correctly recognises, that it
> _doesn't_ get used uninitialised.

hmm... this was with:
$ arm-none-linux-gnueabi-gcc --version
arm-none-linux-gnueabi-gcc (CodeSourcery Sourcery G++ Lite 2007q1-21)
4.2.0 20070413 (prerelease)

...and also with:
$ arm-none-linux-gnueabi-gcc --version
arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2008q3-72) 4.3.2

>> I can take patches 1 and 2 through the async_tx tree, or if you would
>> rather, add my Acked-by to those and take 1-4 through the MXC tree.
>> I'll be sending the async_tx pull request for 2.6.29 in the next few
>> days.
>
> Thanks, great! Don't know what's better, let's see what Sascha says. But
> there's one small problem with the patch 2/4: it breaks compilation on
> i.MX31 if IPU is _not_ set, so, default imx31 configs would break:-( The
> problem is, that I use CONFIG_MX3_IPU_IRQS unconditionally in calculation
> of NR_IRQ. The easiest for me is to fix it in mx31.h like
>
> #ifdef CONFIG_MX3_IPU_IRQS
> #define MX3_IPU_IRQS CONFIG_MX3_IPU_IRQS
> #else
> #define MX3_IPU_IRQS 0
> #endif
>
> but that's less than elegant:-) A probably better solution would be to fix
> this in Kconfig, best would be to show

I think the header file is the proper place for this... the Kconfig
trickery ends up being just another way to say !CONFIG_MX3_IPU_IRQS.

Regards,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/