Re: [PATCH 03/23] cris: introduce asm/swab.h

From: Linus Torvalds
Date: Tue Jan 06 2009 - 16:59:34 EST




On Tue, 6 Jan 2009, Harvey Harrison wrote:
>
> cris holds its arch overrides in an arch/ folder, rename these
> byteorder.h files to swab.h and include them from asm/swab.h
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---
> arch/cris/include/arch-v10/arch/byteorder.h | 28 ---------------------------
> arch/cris/include/arch-v10/arch/swab.h | 28 +++++++++++++++++++++++++++
> arch/cris/include/arch-v32/arch/byteorder.h | 22 ---------------------
> arch/cris/include/arch-v32/arch/swab.h | 22 +++++++++++++++++++++


Since you'e a git user, and you're basically renaming files while then
putting a new name in place, can you please send patches done with both
the "-M" flag (rename detection) _and_ the "-B" flag (which breaks
associations of files even if the name stays the same)?

It's rare that this is needed, but it really helps. Now the patches look
like a big delete/create event, and it's not at all obvious that the code
is actually the same before and after.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/