Re: [PATCH v7 0/8] Tunable sched_mc_power_savings=n

From: Mike Galbraith
Date: Wed Jan 07 2009 - 03:59:32 EST


I have a couple questions if you don't mind.

In wake_idle() there's an odd looking check for kthreads. Why does it
matter if a kbuild task wakes kernel or userland helper thread?

I also don't see why sched_mc overrides domain tunings. You can turn
NEWIDLE off and sched_mc remains as set, so it's a one-way override. If
NEWIDLE is a requirement for sched_mc > 0, it seems only logical to set
sched_mc to 0 if the user explicitly disables NEWIDLE.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/