Re: Data corruption issue with splice() on 2.6.27.10

From: Herbert Xu
Date: Wed Jan 07 2009 - 04:52:52 EST


On Wed, Jan 07, 2009 at 07:38:59AM +0100, Willy Tarreau wrote:
>
> > Unfortunately, once the pipe is fed into sendpage we only use
> > page reference counting to pin down the memory. So as soon as
> > sendpage returns we drop the ref count on the skb, thus freeing
> > the memory in skb->head, which is yet to be transmitted.
>
> So this means that anything relying on sendpage() is at risk ? What

No the bug is in the splice code. sendfile() and other sendpage
users are not affected.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/